• Sam Lantinga's avatar
    Fixed bug #292 · 64fd559c
    Sam Lantinga authored
    I might be on crack here.
    
    It looks like SDL_ConvertMono() in src/audio/SDL_audiocvt.c adds the left and
    right channels of a stereo stream together, and clamps the new mono channel if
    it would overflow.
    
    Shouldn't it be dividing by 2 to average the two sample points instead of
    clamping? Otherwise the mono sample point's volume doubles in the conversion.
    This would also make the conversion faster, as it replaces two branches per
    sample frame with a bitwise shift.
    
    --ryan.
    
    --HG--
    branch : SDL-1.2
    extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/branches/SDL-1.2%402118
    64fd559c
SDL_audiocvt.c 32.4 KB