• Sam Lantinga's avatar
    Von: Thomas Zimmermann · e526b618
    Sam Lantinga authored
    Betreff: [SDL] [PATCH] Make static variables const
    Datum: Tue, 19 May 2009 19:45:37 +0200
    
    Hi,
    
    this is a set of simple changes which make some of SDL's internal static
    arrays constant. The purpose is to shrink the number of write-able
    static bytes and thus increase the number of memory pages shared between
    SDL applications.
    
    The patch set is against trunk@4513. Each of the attached patch files is
    specific to a sub-system. The set is completed by a second mail, because
    of the list's 40 KiB limit.
    
    The files readelf-r4513.txt and readelf-const-patch.txt where made by
    calling 'readelf -S libSDL.so'. They show the difference in ELF sections
    without and with the patch. Some numbers measured on my x86-64:
    
    Before
    
     [13] .rodata           PROGBITS         00000000000eaaa0  000eaaa0
          0000000000008170  0000000000000000   A       0     0     32
     [19] .data.rel.ro      PROGBITS         00000000003045e0  001045e0
          00000000000023d0  0000000000000000  WA       0     0     32
     [23] .data             PROGBITS         00000000003076e0  001076e0
          0000000000004988  0000000000000000  WA       0     0     32
    
    After
    
     [13] .rodata           PROGBITS         00000000000eaaa0  000eaaa0
          0000000000009a50  0000000000000000   A       0     0     32
     [19] .data.rel.ro      PROGBITS         0000000000306040  00106040
          0000000000002608  0000000000000000  WA       0     0     32
     [23] .data             PROGBITS         0000000000309360  00109360
          0000000000002e88  0000000000000000  WA       0     0     32
    
    The size of the write-able data section decreased considerably. Some
    entries became const-after-relocation, while most of its content went
    straight into the read-only data section.
    
    Best regards, Thomas
    
    --HG--
    extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%403618
    e526b618
SDL_systhread.c 2.91 KB
/*
    SDL - Simple DirectMedia Layer
    Copyright (C) 1997-2009 Sam Lantinga

    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Lesser General Public
    License as published by the Free Software Foundation; either
    version 2.1 of the License, or (at your option) any later version.

    This library is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
    Lesser General Public License for more details.

    You should have received a copy of the GNU Lesser General Public
    License along with this library; if not, write to the Free Software
    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA

    Sam Lantinga
    slouken@libsdl.org
*/
#include "SDL_config.h"

#include <pthread.h>
#include <signal.h>

#include "SDL_thread.h"
#include "../SDL_thread_c.h"
#include "../SDL_systhread.h"

/* List of signals to mask in the subthreads */
static const int sig_list[] = {
    SIGHUP, SIGINT, SIGQUIT, SIGPIPE, SIGALRM, SIGTERM, SIGCHLD, SIGWINCH,
    SIGVTALRM, SIGPROF, 0
};

#ifdef __RISCOS__
/* RISC OS needs to know the main thread for
 * it's timer and event processing. */
int riscos_using_threads = 0;
Uint32 riscos_main_thread = 0;  /* Thread running events */
#endif


static void *
RunThread(void *data)
{
    SDL_RunThread(data);
    pthread_exit((void *) 0);
    return ((void *) 0);        /* Prevent compiler warning */
}

int
SDL_SYS_CreateThread(SDL_Thread * thread, void *args)
{
    pthread_attr_t type;

    /* Set the thread attributes */
    if (pthread_attr_init(&type) != 0) {
        SDL_SetError("Couldn't initialize pthread attributes");
        return (-1);
    }
    pthread_attr_setdetachstate(&type, PTHREAD_CREATE_JOINABLE);

    /* Create the thread and go! */
    if (pthread_create(&thread->handle, &type, RunThread, args) != 0) {
        SDL_SetError("Not enough resources to create thread");
        return (-1);
    }
#ifdef __RISCOS__
    if (riscos_using_threads == 0) {
        riscos_using_threads = 1;
        riscos_main_thread = SDL_ThreadID();
    }
#endif

    return (0);
}

void
SDL_SYS_SetupThread(void)
{
    int i;
    sigset_t mask;

    /* Mask asynchronous signals for this thread */
    sigemptyset(&mask);
    for (i = 0; sig_list[i]; ++i) {
        sigaddset(&mask, sig_list[i]);
    }
    pthread_sigmask(SIG_BLOCK, &mask, 0);

#ifdef PTHREAD_CANCEL_ASYNCHRONOUS
    /* Allow ourselves to be asynchronously cancelled */
    {
        int oldstate;
        pthread_setcanceltype(PTHREAD_CANCEL_ASYNCHRONOUS, &oldstate);
    }
#endif
}

/* WARNING:  This may not work for systems with 64-bit pid_t */
Uint32
SDL_ThreadID(void)
{
    return ((Uint32) pthread_self());
}

void
SDL_SYS_WaitThread(SDL_Thread * thread)
{
    pthread_join(thread->handle, 0);
}

/* vi: set ts=4 sw=4 expandtab: */