Skip to content

L
libSDL
Switch branch/tag
  1. 20 Aug, 2005 1 commit
  3. 18 Aug, 2005 3 commits
    • Ryan C. Gordon's avatar
      Patch by me to fix crash described below. · 351fcc95
      Ryan C. Gordon authored 
      --ryan.



To: sdl@libsdl.org
From: Rainer Deyke <rainerd@eldwood.com>
Date: Tue, 16 Aug 2005 01:08:18 -0600
Subject: [SDL] Bug report: SDL_CreateRGBSurface with SDL_HWSURFACE crashes

If SDL is in full-screen mode with a hardware video surface on OS X,
SDL_CreateRGBSurface with SDL_HWSURFACE crashes.  The crash occurs on
line 109 of SDL_Surface.c.  This was tested on OS X 10.3.9 with both SDL
1.2.8 and the latest CVS.  Here is a small C++ program that demonstrates
the problem:

#include "SDL.h"
#include <stdio.h>

namespace {

   void wait_for_key()
   {
     SDL_Event e;
     printf("%d\n", SDL_GetAppState());
     while (SDL_WaitEvent(&e)) {
       if (e.type == SDL_KEYDOWN || e.type == SDL_QUIT) return;
     }
   }

}

int main(int, char *[])
{
   SDL_Init(SDL_INIT_VIDEO);
   SDL_Surface *screen
     = SDL_SetVideoMode(640, 480, 32, SDL_FULLSCREEN | SDL_HWSURFACE);
   SDL_Surface *s = SDL_CreateRGBSurface(SDL_HWSURFACE, 640, 480, 32,
       screen->format->Rmask, screen->format->Gmask,
       screen->format->Bmask, screen->format->Amask);
   wait_for_key();
   if (s) SDL_FreeSurface(s);
   SDL_Quit();
   printf("Success!\n");
   return 0;
}

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401121
      351fcc95
    • Ryan C. Gordon's avatar
      SDL_GetAppState() correction when toggling fullscreen on OSX. · 70bdab5c
      Ryan C. Gordon authored 
      Patch by me to address this comment on the SDL mailing list:

"There appears to be a serious bug with SDL_GetAppState on OS X (10.3.9). When
first running in windowed mode and then switching to full screen mode by
calling SDL_SetVideoMode, SDL_GetAppState returns 4 (SDL_APPACTIVE) instead of
7 (SDL_APPMOUSEFOCUS | SDL_APPINPUTFOCUS | SDL_APPACTIVE).  However, the SDL
application clearly does have the keyboard focus, since it is able to receive
keyboard events."

--ryan.

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401120
      70bdab5c
    • Ryan C. Gordon's avatar
      Date: Wed, 17 Aug 2005 11:23:40 -0400 · 46591960
      Ryan C. Gordon authored 
      From: Matt L <prometheus.uw@gmail.com>
To: "Ryan C. Gordon" <icculus@clutteredmind.org>
Subject: SDL Patch

Hio,

I saw your last call on the mailing list. Here's a patch which I
submitted about two weeks ago which hasn't made it in.

In the current sdl.m4, there's a bug where if your configure.ac, you
have AC_LANG(C++) specified, it won't properly compile and link the SDL
test program when you run the configure script. This is because only the
default CFLAGS is overriden in sdl.m4, and in the patch below, I've
fixed it so it overrides CXXFLAGS as well, allowing it to work with g++.

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401119
      46591960
  5. 17 Aug, 2005 1 commit
    • Ryan C. Gordon's avatar
      From: Jim Paris <jim_jtan_com> · 17254837
      Ryan C. Gordon authored 
      To: sdl@libsdl.org
Date: Sat, 9 Jul 2005 13:59:33 -0400
Subject: [PATCH] fix locking in src/timer/SYS_timer.c

SDL_SetTimer has a typo in CVS.  This code was added since 1.2.8.  The
result is that the SDL_timer_mutex is locked twice and never unlocked,
breaking systems that use a threaded timer implementation.

-jim

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401118
      17254837
  7. 16 Aug, 2005 1 commit
  9. 11 Aug, 2005 3 commits
  11. 10 Aug, 2005 2 commits
  13. 09 Aug, 2005 1 commit
  15. 08 Aug, 2005 2 commits
  17. 07 Aug, 2005 1 commit
  19. 29 Jul, 2005 2 commits
  21. 27 Jul, 2005 3 commits
  23. 21 Jul, 2005 3 commits
  25. 20 Jul, 2005 4 commits
  27. 18 Jul, 2005 1 commit
  29. 17 Jul, 2005 1 commit
  31. 07 Jul, 2005 5 commits
  33. 01 Jul, 2005 1 commit
  35. 30 Jun, 2005 3 commits
  37. 29 Jun, 2005 2 commits