Skip to content

L
libSDL
Switch branch/tag
  1. 20 Feb, 2006 1 commit
  3. 19 Feb, 2006 8 commits
  5. 18 Feb, 2006 4 commits
  7. 17 Feb, 2006 1 commit
  9. 16 Feb, 2006 6 commits
  11. 10 Feb, 2006 6 commits
  13. 09 Feb, 2006 3 commits
  15. 08 Feb, 2006 6 commits
    • Ryan C. Gordon's avatar
      Changed X11 header order so it works on Solaris. · 6c427bdf
      Ryan C. Gordon authored 
         Fixes Bugzilla #138.

--ryan.

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401355
      6c427bdf
    • Patrice Mandin's avatar
      Fixes for new SDL embedded libc stuff · 83e8409a
      Patrice Mandin authored 
      --HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401354
      83e8409a
    • Sam Lantinga's avatar
      *** empty log message *** · 46432938
      Sam Lantinga authored 
      --HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401353
      46432938
    • Sam Lantinga's avatar
      Date: Mon, 6 Feb 2006 11:41:04 -0500 · fc0f66b5
      Sam Lantinga authored 
      From: "mystml@adinet.com.uy"
Subject: [SDL] ALT-F4 using DirectX

My game isn't getting SDL_QUIT when I press ALT-F4 using the DirectX
driver; it does get SDL_QUIT when I press the red X in the window.

I tracked this down to DX5_HandleMessage() in SDL_dx5events.c;
WM_SYSKEYDOWN is being trapped and ignored which causes Windows not to post
a WM_CLOSE, hence no SDL_QUIT is being generated.

The relevant code is this :

                /* The keyboard is handled via DirectInput */
                case WM_SYSKEYUP:
                case WM_SYSKEYDOWN:
                case WM_KEYUP:
                case WM_KEYDOWN: {
                        /* Ignore windows keyboard messages */;
                }
                return(0);

If I comment the WM_SYSKEYDOWN case, it falls through DefWindowProc() and
ALT-F4 starts working again.

I'm not sure about the best way to fix this. One option is handling ALT-F4
as a particular case somehow, but doesn't sound good. Another option would
be to handle WM_SYSKEYDOWN separately and breaking instead of returning 0,
so processing falls through and goes to DefWindowProc which does The Right
Thing (TM). This seems to be the minimal change that makes ALT-F4 work and
normal keyboard input continues to work.

Does this sound reasonable? Am I overlooking anything? Do I submit a patch?

--Gabriel

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401352
      fc0f66b5
    • Sam Lantinga's avatar
      Check for strtod · 30598fe2
      Sam Lantinga authored 
      --HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401351
      30598fe2
    • Sam Lantinga's avatar
      Default to build SDL without MSVCRT · 940b3988
      Sam Lantinga authored 
      --HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401350
      940b3988
  17. 07 Feb, 2006 5 commits