• Sam Lantinga's avatar
    Fixed bug #611 · 140163c3
    Sam Lantinga authored
    From  Tim Angus   2008-08-12 11:18:06
    
    I'm one of the maintainers of ioquake3.org, an updated version of the
    Quake 3 engine. Relatively recently, we moved ioq3 to use SDL as a
    replacement for 95% of the platform specific code that was there. On the
    whole it's doing a great job but unfortunately since the move we've been
    getting complaints about the quality of the mouse input on the Windows
    platform to the point where for many the game is unplayable. Put in
    other terms, the current stable SDL 1.2 is basically not fit for purpose
    if you need high quality mouse input as you do in a first person shooter.
    
    Over the weekend I decided to pull my finger out and actually figure out
    what's going on. There are basically two major problems. Firstly, when
    using the "windib" driver, mouse input is gathered via the WM_MOUSEMOVE
    message. Googling for this indicates that often this is known to result
    in "spurious" and/or "missing" mouse movement events; this is the
    primary cause of the poor mouse input. The second problem is that the
    "directx" driver does not work at all in combination with OpenGL meaning
    that you can't use DirectInput if your application also uses OpenGL. In
    other words you're locked into using the "windib" driver and its poor
    mouse input.
    
    In order to address these problems I've done the following:
    
    * Remove WM_MOUSEMOVE based motion event generation and replace with
    calls to GetCursorPos which seems much more reliable. In order to
    achieve this I've moved mouse motion out into a separate function that
    is called once per DIB_PumpEvents.
    
    * Remove the restriction on the "directx" driver being inoperable in
    combination with OpenGL. There is a bug for this issues that I've
    hijacked to a certain extent
    (http://bugzilla.libsdl.org/show_bug.cgi?id=265). I'm the first to admit
    I don't really understand why this restriction is there in the first
    place. The commit message for the bug fix that introduced this
    restriction (r581) isn't very elaborate and I couldn't see any other bug
    tracking the issue. If anyone has more information on the bug that was
    avoided by r581 it would be helpful as I/someone could then look into
    addressing the problem without disabling the "directx" driver.
    
    * I've also removed the restriction on not being allowed to use
    DirectInput in windowed mode. I couldn't see any reason for this, at
    least not from our perspective. I have my suspicions that it'll be
    something like matching up the cursor with the mouse coordinates...
    
    * I bumped up the DirectInput API used to version 7 in order to get
    access to mouse buttons 4-7. I've had to inject a little bit of the DX7
    headers into SDL there as the MinGW ones aren't up to date in this respect.
    
    --HG--
    branch : SDL-1.2
    extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/branches/SDL-1.2%403572
    140163c3
Name
Last commit
Last update
..
audio Loading commit data...
cdrom Loading commit data...
cpuinfo Loading commit data...
events Loading commit data...
file Loading commit data...
hermes Loading commit data...
joystick Loading commit data...
loadso Loading commit data...
main Loading commit data...
stdlib Loading commit data...
thread Loading commit data...
timer Loading commit data...
video Loading commit data...
SDL.c Loading commit data...
SDL_error.c Loading commit data...
SDL_error_c.h Loading commit data...
SDL_fatal.c Loading commit data...
SDL_fatal.h Loading commit data...