• Sam Lantinga's avatar
    Fixed bug #208 · 1c057bf3
    Sam Lantinga authored
    So, here's a patch with a reimplementation of QZ_SetIcon() that does what I
    described above. I apologize for the delay, I've been quite busy in the last
    few days.
    
    It appears to work here on 10.4.5 PPC in the limited testing that I've done;
    I'll try to test it on 10.3.9 and 10.2.8 as well, but that might take another
    week or so. Please test on i386.
    
    Regarding alpha channels, per-surface alpha, and color keys, the same semantics
    as for regular blits to an RGB surface should apply (for the final icon
    composited onto the dock), unless I made a mistake - except in one pathological
    case: if the icon surface has an alpha channel, its SDL_SRCALPHA flag is not
    set (i.e. it has been explicitly cleared, since it's on by default for RGBA
    surfaces), and it has a color key, plus an explicit mask was specified (instead
    of the one autogenerated from the colorkey), then the color-keyed areas appear
    black instead of transparent. I found no elegant way of fixing this, was too
    lazy to implement the inelegant one, and decided that it isn't worth the effort
    (but if someone disagrees, I can do it).
    
    --HG--
    extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401773
    1c057bf3
Name
Last commit
Last update
..
Xext Loading commit data...
aalib Loading commit data...
ataricommon Loading commit data...
bwindow Loading commit data...
cybergfx Loading commit data...
dc Loading commit data...
dga Loading commit data...
directfb Loading commit data...
dummy Loading commit data...
epoc Loading commit data...
fbcon Loading commit data...
gapi Loading commit data...
gem Loading commit data...
ggi Loading commit data...
ipod Loading commit data...
maccommon Loading commit data...
macdsp Loading commit data...
macrom Loading commit data...
nanox Loading commit data...
os2fslib Loading commit data...
photon Loading commit data...
picogui Loading commit data...
ps2gs Loading commit data...
qtopia Loading commit data...
quartz Loading commit data...
riscos Loading commit data...
svga Loading commit data...
vgl Loading commit data...
wincommon Loading commit data...
windib Loading commit data...
windx5 Loading commit data...
wscons Loading commit data...
x11 Loading commit data...
xbios Loading commit data...
SDL_RLEaccel.c Loading commit data...
SDL_RLEaccel_c.h Loading commit data...
SDL_blit.c Loading commit data...
SDL_blit.h Loading commit data...
SDL_blit_0.c Loading commit data...
SDL_blit_1.c Loading commit data...
SDL_blit_A.c Loading commit data...
SDL_blit_N.c Loading commit data...
SDL_bmp.c Loading commit data...
SDL_cursor.c Loading commit data...
SDL_cursor_c.h Loading commit data...
SDL_gamma.c Loading commit data...
SDL_glfuncs.h Loading commit data...
SDL_leaks.h Loading commit data...
SDL_pixels.c Loading commit data...
SDL_pixels_c.h Loading commit data...
SDL_stretch.c Loading commit data...
SDL_stretch_c.h Loading commit data...
SDL_surface.c Loading commit data...
SDL_sysvideo.h Loading commit data...
SDL_video.c Loading commit data...
SDL_yuv.c Loading commit data...
SDL_yuv_mmx.c Loading commit data...
SDL_yuv_sw.c Loading commit data...
SDL_yuv_sw_c.h Loading commit data...
SDL_yuvfuncs.h Loading commit data...
blank_cursor.h Loading commit data...
default_cursor.h Loading commit data...
e_log.h Loading commit data...
e_pow.h Loading commit data...
e_sqrt.h Loading commit data...
math_private.h Loading commit data...
mmx.h Loading commit data...