• Ryan C. Gordon's avatar
    From: Gabriel Gambetta · 7a800234
    Ryan C. Gordon authored
    To: SDL Mailing List <sdl@libsdl.org>
    Date: Fri, 17 Nov 2006 00:39:29 -0200
    Subject: [SDL] Alpha blending bug - fixed?
    
    It turns out mm5 never got the correct value. This failed :
    
    	[...]
    	"movd %1, %%mm5\n\t"
    	: : "m" (amask), "m" (sf->Ashift) );
    
    
    mm5 got 0xFF000018 instead of 0x00000018. However I did this :
    
    	Uint32 ashift = sf->Ashift;
    	[...]
    	"movd %1, %%mm5\n\t"
    	: : "m" (amask), "m" (ashift) );
    
    and everything worked fine.
    
    The only thing I could find out was that ashift is 32-bit aligned but
    sf->Ashift isn't:
    
    printf("ashift     %8X [%d]\n", &ashift, (int)(&ashift) % 4);
    printf("sf->Ashift %8X [%d]\n", &sf->Ashift, (int)(&sf->Ashift) % 4);
    
    ashift     at BFF0E0C4 [0]
    sf->Ashift at 08AFB9CD [1]
    
    Could this be the problem? If it is, the fix is extremely trivial.
    Should I submit a patch?
    
    	--Gabriel
    
    --HG--
    branch : SDL-1.2
    extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/branches/SDL-1.2%402236
    7a800234
Name
Last commit
Last update
build-scripts Loading commit data...
docs Loading commit data...
include Loading commit data...
src Loading commit data...
test Loading commit data...
BUGS Loading commit data...
Borland.html Loading commit data...
Borland.zip Loading commit data...
COPYING Loading commit data...
CREDITS Loading commit data...
CWprojects.sea.bin Loading commit data...
EpocBuildFiles.zip Loading commit data...
INSTALL Loading commit data...
MPWmake.sea.bin Loading commit data...
Makefile.dc Loading commit data...
Makefile.in Loading commit data...
Makefile.minimal Loading commit data...
README Loading commit data...
README-SDL.txt Loading commit data...
README.AmigaOS Loading commit data...
README.BeOS Loading commit data...
README.CVS Loading commit data...
README.DC Loading commit data...
README.Epoc Loading commit data...
README.MacOS Loading commit data...
README.MacOSX Loading commit data...
README.MiNT Loading commit data...
README.NanoX Loading commit data...
README.OS2 Loading commit data...
README.PicoGUI Loading commit data...
README.Porting Loading commit data...
README.QNX Loading commit data...
README.Qtopia Loading commit data...
README.RISCOS Loading commit data...
README.SVN Loading commit data...
README.Watcom Loading commit data...
README.WinCE Loading commit data...
README.wscons Loading commit data...
SDL.qpg.in Loading commit data...
SDL.spec.in Loading commit data...
TODO Loading commit data...
VisualC.html Loading commit data...
VisualC.zip Loading commit data...
VisualCE.zip Loading commit data...
Watcom-OS2.zip Loading commit data...
Watcom-Win32.zip Loading commit data...
WhatsNew Loading commit data...
acinclude.m4 Loading commit data...
autogen.sh Loading commit data...
configure.in Loading commit data...
docs.html Loading commit data...
sdl-config.in Loading commit data...
sdl.m4 Loading commit data...
sdl.pc.in Loading commit data...