• Ryan C. Gordon's avatar
    From: Gabriel Gambetta · 7a800234
    Ryan C. Gordon authored
    To: SDL Mailing List <sdl@libsdl.org>
    Date: Fri, 17 Nov 2006 00:39:29 -0200
    Subject: [SDL] Alpha blending bug - fixed?
    
    It turns out mm5 never got the correct value. This failed :
    
    	[...]
    	"movd %1, %%mm5\n\t"
    	: : "m" (amask), "m" (sf->Ashift) );
    
    
    mm5 got 0xFF000018 instead of 0x00000018. However I did this :
    
    	Uint32 ashift = sf->Ashift;
    	[...]
    	"movd %1, %%mm5\n\t"
    	: : "m" (amask), "m" (ashift) );
    
    and everything worked fine.
    
    The only thing I could find out was that ashift is 32-bit aligned but
    sf->Ashift isn't:
    
    printf("ashift     %8X [%d]\n", &ashift, (int)(&ashift) % 4);
    printf("sf->Ashift %8X [%d]\n", &sf->Ashift, (int)(&sf->Ashift) % 4);
    
    ashift     at BFF0E0C4 [0]
    sf->Ashift at 08AFB9CD [1]
    
    Could this be the problem? If it is, the fix is extremely trivial.
    Should I submit a patch?
    
    	--Gabriel
    
    --HG--
    branch : SDL-1.2
    extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/branches/SDL-1.2%402236
    7a800234
Name
Last commit
Last update
..
Xext Loading commit data...
aalib Loading commit data...
ataricommon Loading commit data...
bwindow Loading commit data...
dc Loading commit data...
dga Loading commit data...
directfb Loading commit data...
dummy Loading commit data...
epoc Loading commit data...
fbcon Loading commit data...
gapi Loading commit data...
gem Loading commit data...
ggi Loading commit data...
ipod Loading commit data...
maccommon Loading commit data...
macdsp Loading commit data...
macrom Loading commit data...
nanox Loading commit data...
os2fslib Loading commit data...
photon Loading commit data...
picogui Loading commit data...
ps2gs Loading commit data...
qtopia Loading commit data...
quartz Loading commit data...
riscos Loading commit data...
svga Loading commit data...
vgl Loading commit data...
wincommon Loading commit data...
windib Loading commit data...
windx5 Loading commit data...
wscons Loading commit data...
x11 Loading commit data...
xbios Loading commit data...
SDL_RLEaccel.c Loading commit data...
SDL_RLEaccel_c.h Loading commit data...
SDL_blit.c Loading commit data...
SDL_blit.h Loading commit data...
SDL_blit_0.c Loading commit data...
SDL_blit_1.c Loading commit data...
SDL_blit_A.c Loading commit data...
SDL_blit_N.c Loading commit data...
SDL_bmp.c Loading commit data...
SDL_cursor.c Loading commit data...
SDL_cursor_c.h Loading commit data...
SDL_gamma.c Loading commit data...
SDL_glfuncs.h Loading commit data...
SDL_leaks.h Loading commit data...
SDL_pixels.c Loading commit data...
SDL_pixels_c.h Loading commit data...
SDL_stretch.c Loading commit data...
SDL_stretch_c.h Loading commit data...
SDL_surface.c Loading commit data...
SDL_sysvideo.h Loading commit data...
SDL_video.c Loading commit data...
SDL_yuv.c Loading commit data...
SDL_yuv_mmx.c Loading commit data...
SDL_yuv_sw.c Loading commit data...
SDL_yuv_sw_c.h Loading commit data...
SDL_yuvfuncs.h Loading commit data...
blank_cursor.h Loading commit data...
default_cursor.h Loading commit data...
e_log.h Loading commit data...
e_pow.h Loading commit data...
e_sqrt.h Loading commit data...
math_private.h Loading commit data...
mmx.h Loading commit data...