• Ryan C. Gordon's avatar
    Some MMX fixes from Patrick Baggett. · ad214ecb
    Ryan C. Gordon authored
    Original email...
    
    Date: Sat, 10 Sep 2011 13:01:20 -0500
    From: Patrick Baggett
    To: SDL Development List <sdl@lists.libsdl.org>
    Subject: Re: [SDL] SDL_memcpyMMX uses SSE instructions
    
    In SDL_blit_copy.c, the function SDL_memcpyMMX() actually use SSE
    instructions.
    
    It is called in this context:
    
    #ifdef __MMX__
        if (SDL_HasMMX() &&
            !((uintptr_t) src & 7) && !(srcskip & 7) &&
            !((uintptr_t) dst & 7) && !(dstskip & 7)) {
            while (h--) {
                SDL_memcpyMMX(dst, src, w);
                src += srcskip;
                dst += dstskip;
            }
            _mm_empty();
            return;
        }
    #endif
    
    This implies that the minimum CPU features are just MMX. There is a
    separate SDL_memcpySSE() function.
    
    
    The SDL_memcpyMMX() function does:
    
    #ifdef __SSE__
            _mm_prefetch(src, _MM_HINT_NTA);
    #endif
    
    ...which tests at compile time if SSE intrinsics are available, not at run
    time. It generates the PREFETCHNTA instruction. It also uses _mm_stream_pi()
    intrinsic, which generates the MOVNTQ instruction.
    
    If you replace the "MMX" code with:
    
    __m64* d64 = (__m64*)dst;
    __m64* s64 = (__m64*)src;
     for(i= len / 64; i--;) {
       d64[0] = s64[0];
       d64[1] = s64[1];
       d64[2] = s64[2];
       d64[3] = s64[3];
       d64[4] = s64[4];
       d64[5] = s64[5];
       d64[6] = s64[6];
       d64[7] = s64[7];
       d64 += 8;
       s64 += 8;
     }
    
    Then MSVC generates the correct movq instructions. GCC (4.5.0) seems to
    think that using 2x movl is still better, but then again, GCC isn't actually
    that good at optimizing intrinsics as I've found. At least the code won't
    crash on my P2 though. :)
    
    Also, there is no requirement for MMX to be aligned to the 8th byte. I
    think the author assumed that SSE's 16 byte alignment requirement must
    retroactively mean that MMX requires 8 byte alignment. Attached is the full
    patch.
    
    Patrick
    ad214ecb
Name
Last commit
Last update
VisualC Loading commit data...
Xcode Loading commit data...
Xcode-iPhoneOS Loading commit data...
acinclude Loading commit data...
android-project Loading commit data...
build-scripts Loading commit data...
include Loading commit data...
src Loading commit data...
test Loading commit data...
.DISABLED-hgeol Loading commit data...
.hgignore Loading commit data...
.hgtags Loading commit data...
.indent.pro Loading commit data...
Android.mk Loading commit data...
BUGS Loading commit data...
Borland.html Loading commit data...
Borland.zip Loading commit data...
COPYING Loading commit data...
CREDITS Loading commit data...
INSTALL Loading commit data...
Makefile.ds Loading commit data...
Makefile.in Loading commit data...
Makefile.minimal Loading commit data...
Makefile.pandora Loading commit data...
Makefile.wiz Loading commit data...
NOTES Loading commit data...
README Loading commit data...
README-SDL.txt Loading commit data...
README.BeOS Loading commit data...
README.DirectFB Loading commit data...
README.HG Loading commit data...
README.MacOSX Loading commit data...
README.Platforms Loading commit data...
README.Porting Loading commit data...
README.Watcom Loading commit data...
README.WinCE Loading commit data...
README.android Loading commit data...
README.ds Loading commit data...
README.gesture Loading commit data...
README.iphoneos Loading commit data...
README.pandora Loading commit data...
README.touch Loading commit data...
SDL.spec.in Loading commit data...
TODO Loading commit data...
UNDER_CONSTRUCTION.txt Loading commit data...
VisualC.html Loading commit data...
Watcom-Win32.zip Loading commit data...
WhatsNew Loading commit data...
aclocal.m4 Loading commit data...
autogen.sh Loading commit data...
configure Loading commit data...
configure.in Loading commit data...
sdl-config.in Loading commit data...
sdl.m4 Loading commit data...
sdl.pc.in Loading commit data...