• Ryan C. Gordon's avatar
    Date: Mon, 17 Oct 2005 20:09:03 -0400 · d8c36bac
    Ryan C. Gordon authored
    From: Mark Schreiber <mark7@alumni.cmu.edu>
    To: ryan@clutteredmind.org
    Subject: [PATCH]SDL mprotect() crash fix
    
    (I'm going to throw this patch your way at the suggestion of #SDL --
    for some reason, I had some difficulty sending it to the main list
    last time, and I go bonkers subscribing to send each email or
    patch...)
    
    Currently, when I run SDL applications as non-root using
    SDL_VIDEODRIVER=dga, the fbdev fallback mprotect()s read/write the
    proper size of mmapped /dev/fb0 (7.5MB), but on framebuffer release
    mprotect()s read-only the range by the entire size of my video memory
    (128MB), which causes a segfault:
    
    #0  0x002a9a27 in ?? () from /lib/libc.so.6
    #1  0x04a63eb6 in SDL_XDGAUnmapFramebuffer (screen=3D0) at XF86DGA2.c:978
    #2  0x04a63efc in SDL_XDGACloseFramebuffer (dpy=3D0x9d3f008, screen=3D0)
        at XF86DGA2.c:268
    #3  0x04a68b57 in DGA_Available () at SDL_dgavideo.c:98
    #4  0x04a53677 in SDL_VideoInit (driver_name=3D0xbfb0bfc7 "dga", flags=3D0)
        at SDL_video.c:180
    #5  0x04a2613f in SDL_InitSubSystem (flags=3D32) at SDL.c:74
    #6  0x04a2617c in SDL_Init (flags=3D32) at SDL.c:166
    #7  0x08049722 in main (argc=3D1, argv=3D0x0) at testwin.c:32
    
    This is SDL 1.2.8 on Fedora Core 4, radeon driver for a Radeon 9250,
    xorg-x11-6.8.2-37.
    
    I've attached a one-line patch against SDL CVS that updates the size
    of the framebuffer at framebuffer map time so that the mprotect() on
    unmap will be the same size.  I'm not sure if this is the best
    approach (i.e. one might want to retain the original value), but it
    does make my SDL applications work without segfaulting.
    
    -- Best of luck, Mark Schreiber
    
    --HG--
    extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401179
    d8c36bac
Name
Last commit
Last update
docs Loading commit data...
include Loading commit data...
src Loading commit data...
test Loading commit data...
.cvsignore Loading commit data...
BUGS Loading commit data...
Borland.html Loading commit data...
Borland.zip Loading commit data...
COPYING Loading commit data...
CREDITS Loading commit data...
CWprojects.sea.bin Loading commit data...
EpocBuildFiles.zip Loading commit data...
INSTALL Loading commit data...
MPWmake.sea.bin Loading commit data...
Makefile.am Loading commit data...
Makefile.dc Loading commit data...
PBProjects.tar.gz Loading commit data...
README Loading commit data...
README-SDL.txt Loading commit data...
README.AmigaOS Loading commit data...
README.CVS Loading commit data...
README.DC Loading commit data...
README.Epoc Loading commit data...
README.MacOS Loading commit data...
README.MacOSX Loading commit data...
README.MiNT Loading commit data...
README.NanoX Loading commit data...
README.PicoGUI Loading commit data...
README.QNX Loading commit data...
README.Qtopia Loading commit data...
README.RISCOS Loading commit data...
README.WinCE Loading commit data...
SDL.qpg.in Loading commit data...
SDL.spec.in Loading commit data...
TODO Loading commit data...
VisualC.html Loading commit data...
VisualC.zip Loading commit data...
VisualCE.zip Loading commit data...
WhatsNew Loading commit data...
acinclude.m4 Loading commit data...
autogen.sh Loading commit data...
config.guess Loading commit data...
config.sub Loading commit data...
configure.in Loading commit data...
docs.html Loading commit data...
ltmain.sh Loading commit data...
sdl-config.in Loading commit data...
sdl.m4 Loading commit data...
strip_fPIC.sh Loading commit data...