• Ryan C. Gordon's avatar
    Date: Sat, 2 Feb 2008 22:08:05 +0100 · dec971d6
    Ryan C. Gordon authored
    From: Marcus von Appen
    To: sdl@lists.libsdl.org
    Subject: [SDL] [Patch] SDL-1.2 SDL_revcpy() asm patch for the cld flag
    
    Hi,
    
    as reported through the FreeBSD bug tracking system in SDL 1.2.13 (and
    in the 1.2 branch, if I see that correctly) the SDL_revcpy() macro sets
    the direction flag (std), but does not clear it afterwards (cld), which
    is wrong according to the GCC and SYS V specs.  This can cause some
    weird side effects, which in turn can lead to memory corruption.
    
    You can read the full report with a detailed description and test
    program at http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/120052
    
    Attached is the submitted patch, which fixes the issue.
    
    Regards
    Marcus
    
    --HG--
    branch : SDL-1.2
    extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/branches/SDL-1.2%402713
    dec971d6
Name
Last commit
Last update
..
SDL.h Loading commit data...
SDL_active.h Loading commit data...
SDL_audio.h Loading commit data...
SDL_byteorder.h Loading commit data...
SDL_cdrom.h Loading commit data...
SDL_config.h.default Loading commit data...
SDL_config.h.in Loading commit data...
SDL_config_dreamcast.h Loading commit data...
SDL_config_macos.h Loading commit data...
SDL_config_macosx.h Loading commit data...
SDL_config_minimal.h Loading commit data...
SDL_config_nds.h Loading commit data...
SDL_config_os2.h Loading commit data...
SDL_config_symbian.h Loading commit data...
SDL_config_win32.h Loading commit data...
SDL_copying.h Loading commit data...
SDL_cpuinfo.h Loading commit data...
SDL_endian.h Loading commit data...
SDL_error.h Loading commit data...
SDL_events.h Loading commit data...
SDL_getenv.h Loading commit data...
SDL_joystick.h Loading commit data...
SDL_keyboard.h Loading commit data...
SDL_keysym.h Loading commit data...
SDL_loadso.h Loading commit data...
SDL_main.h Loading commit data...
SDL_mouse.h Loading commit data...
SDL_mutex.h Loading commit data...
SDL_name.h Loading commit data...
SDL_opengl.h Loading commit data...
SDL_platform.h Loading commit data...
SDL_quit.h Loading commit data...
SDL_rwops.h Loading commit data...
SDL_stdinc.h Loading commit data...
SDL_syswm.h Loading commit data...
SDL_thread.h Loading commit data...
SDL_timer.h Loading commit data...
SDL_types.h Loading commit data...
SDL_version.h Loading commit data...
SDL_video.h Loading commit data...
begin_code.h Loading commit data...
close_code.h Loading commit data...