• Sam Lantinga's avatar
    Fixed bug #1056 (Frequent crashes in Touch events by simply touching the screen) · e64d0e8d
    Sam Lantinga authored
     Joseba García Echebarria      2010-12-15 01:55:22 PST
    
    I believe the crash is caused by a check not being performed on wether an
    SDL_Touch element is NULL before using it in the SDL_SendTouchMotion function
    in src/events/SDL_touch.c around line 400.
    Judging from the rest of the code, there's a missing
    
        if (!touch) {
            return 0;
        }
    
    before using "touch" as SDL_GetFinger(), SDL_GetFingerIndexId() use
    touch->num_fingers without checking.
    
    I can attach a patch if you like. It seems pretty straightforward, though.
    
    I have yet to discover why touch is being returned as NULL as this error is
    only triggered when an actual gesture has been performed, maybe something
    related to SDL_AddTouch()?
    e64d0e8d
Name
Last commit
Last update
VisualC Loading commit data...
VisualCE Loading commit data...
Xcode Loading commit data...
Xcode-iPhoneOS Loading commit data...
acinclude Loading commit data...
android-project Loading commit data...
build-scripts Loading commit data...
include Loading commit data...
src Loading commit data...
test Loading commit data...
.DISABLED-hgeol Loading commit data...
.hgignore Loading commit data...
.hgtags Loading commit data...
.indent.pro Loading commit data...
Android.mk Loading commit data...
BUGS Loading commit data...
Borland.html Loading commit data...
Borland.zip Loading commit data...
COPYING Loading commit data...
CREDITS Loading commit data...
INSTALL Loading commit data...
Makefile.ds Loading commit data...
Makefile.in Loading commit data...
Makefile.minimal Loading commit data...
Makefile.pandora Loading commit data...
Makefile.wiz Loading commit data...
NOTES Loading commit data...
README Loading commit data...
README-SDL.txt Loading commit data...
README.BeOS Loading commit data...
README.DirectFB Loading commit data...
README.HG Loading commit data...
README.MacOSX Loading commit data...
README.Platforms Loading commit data...
README.Porting Loading commit data...
README.QNX Loading commit data...
README.Watcom Loading commit data...
README.WinCE Loading commit data...
README.android Loading commit data...
README.gesture Loading commit data...
README.iphoneos Loading commit data...
README.pandora Loading commit data...
README.touch Loading commit data...
SDL.spec.in Loading commit data...
TODO Loading commit data...
UNDER_CONSTRUCTION.txt Loading commit data...
VisualC.html Loading commit data...
Watcom-Win32.zip Loading commit data...
WhatsNew Loading commit data...
autogen.sh Loading commit data...
configure.in Loading commit data...
sdl-config.in Loading commit data...
sdl.m4 Loading commit data...
sdl.pc.in Loading commit data...