Fixed bug #852

Jesse Anders 2009-10-17 14:17:25 PDT In VC++, the build script that creates SDL_config.h and SDL_revision.h fails when the project directory path includes spaces. For example, if the project directory path is: c:\Documents and Settings\Jesse\My Documents\Visual Studio 2008\Projects\SDL 1.3\VisualC\SDL\ The following error is generated: 'and' is not recognized as an internal or external command Placing all paths in quotes fixes this. --HG-- extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%404106

Fixed bug #852
Jesse Anders 2009-10-17 14:17:25 PDT In VC++, the build script that creates SDL_config.h and SDL_revision.h fails when the project directory path includes spaces. For example, if the project directory path is: c:\Documents and Settings\Jesse\My Documents\Visual Studio 2008\Projects\SDL 1.3\VisualC\SDL\ The following error is generated: 'and' is not recognized as an internal or external command Placing all paths in quotes fixes this. --HG-- extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%404106
c331a14c · Sam Lantinga · 6513f302 · c331a14c · c331a14c · c331a14c
Commit c331a14c authored Oct 17, 2009 by Sam Lantinga
Showing with 10 additions and 10 deletions

SDL.vcproj VisualC/SDL/SDL.vcproj +2 -2

SDL_VS2008.vcproj VisualC/SDL/SDL_VS2008.vcproj +2 -2

SDLmain.vcproj VisualC/SDLmain/SDLmain.vcproj +3 -3

SDLmain_VS2008.vcproj VisualC/SDLmain/SDLmain_VS2008.vcproj +3 -3

No files found.
--- a/VisualC/SDL/SDL.vcproj
+++ b/VisualC/SDL/SDL.vcproj
@@ -26,7 +26,7 @@
 			<Tool
 				Name="VCPreBuildEventTool"
 				Description="Making sure basic SDL headers are in place..."
-				CommandLine="if exist $(ProjectDir)\..\..\include\SDL_config.h goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy $(ProjectDir)\..\..\include\SDL_config_win32.h $(ProjectDir)\..\..\include\SDL_config.h&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist $(ProjectDir)\..\..\include\SDL_revision.h goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;$(ProjectDir)\..\..\include\SDL_revision.h&#x0D;&#x0A;:SDLREVISIONOKAY"
+				CommandLine="if exist "$(ProjectDir)\..\..\include\SDL_config.h" goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy "$(ProjectDir)\..\..\include\SDL_config_win32.h" "$(ProjectDir)\..\..\include\SDL_config.h"&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist "$(ProjectDir)\..\..\include\SDL_revision.h" goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;"$(ProjectDir)\..\..\include\SDL_revision.h"&#x0D;&#x0A;:SDLREVISIONOKAY"
 			/>
 			<Tool
 				Name="VCCustomBuildTool"
@@ -125,7 +125,7 @@
 			<Tool
 				Name="VCPreBuildEventTool"
 				Description="Making sure basic SDL headers are in place..."
-				CommandLine="if exist $(ProjectDir)\..\..\include\SDL_config.h goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy $(ProjectDir)\..\..\include\SDL_config_win32.h $(ProjectDir)\..\..\include\SDL_config.h&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist $(ProjectDir)\..\..\include\SDL_revision.h goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;$(ProjectDir)\..\..\include\SDL_revision.h&#x0D;&#x0A;:SDLREVISIONOKAY"
+				CommandLine="if exist "$(ProjectDir)\..\..\include\SDL_config.h" goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy "$(ProjectDir)\..\..\include\SDL_config_win32.h" "$(ProjectDir)\..\..\include\SDL_config.h"&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist "$(ProjectDir)\..\..\include\SDL_revision.h" goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;"$(ProjectDir)\..\..\include\SDL_revision.h"&#x0D;&#x0A;:SDLREVISIONOKAY"
 			/>
 			<Tool
 				Name="VCCustomBuildTool"

--- a/VisualC/SDL/SDL_VS2008.vcproj
+++ b/VisualC/SDL/SDL_VS2008.vcproj
@@ -30,7 +30,7 @@
 			<Tool
 				Name="VCPreBuildEventTool"
 				Description="Making sure basic SDL headers are in place..."
-				CommandLine="if exist $(ProjectDir)\..\..\include\SDL_config.h goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy $(ProjectDir)\..\..\include\SDL_config_win32.h $(ProjectDir)\..\..\include\SDL_config.h&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist $(ProjectDir)\..\..\include\SDL_revision.h goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;$(ProjectDir)\..\..\include\SDL_revision.h&#x0D;&#x0A;:SDLREVISIONOKAY"
+				CommandLine="if exist "$(ProjectDir)\..\..\include\SDL_config.h" goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy "$(ProjectDir)\..\..\include\SDL_config_win32.h" "$(ProjectDir)\..\..\include\SDL_config.h"&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist "$(ProjectDir)\..\..\include\SDL_revision.h" goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;"$(ProjectDir)\..\..\include\SDL_revision.h"&#x0D;&#x0A;:SDLREVISIONOKAY"
 			/>
 			<Tool
 				Name="VCCustomBuildTool"
@@ -201,7 +201,7 @@
 			<Tool
 				Name="VCPreBuildEventTool"
 				Description="Making sure basic SDL headers are in place..."
-				CommandLine="if exist $(ProjectDir)\..\..\include\SDL_config.h goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy $(ProjectDir)\..\..\include\SDL_config_win32.h $(ProjectDir)\..\..\include\SDL_config.h&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist $(ProjectDir)\..\..\include\SDL_revision.h goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;$(ProjectDir)\..\..\include\SDL_revision.h&#x0D;&#x0A;:SDLREVISIONOKAY"
+				CommandLine="if exist "$(ProjectDir)\..\..\include\SDL_config.h" goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy "$(ProjectDir)\..\..\include\SDL_config_win32.h" "$(ProjectDir)\..\..\include\SDL_config.h"&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist "$(ProjectDir)\..\..\include\SDL_revision.h" goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;"$(ProjectDir)\..\..\include\SDL_revision.h"&#x0D;&#x0A;:SDLREVISIONOKAY"
 			/>
 			<Tool
 				Name="VCCustomBuildTool"

--- a/VisualC/SDLmain/SDLmain.vcproj
+++ b/VisualC/SDLmain/SDLmain.vcproj
@@ -25,7 +25,7 @@
 			<Tool
 				Name="VCPreBuildEventTool"
 				Description="Making sure basic SDL headers are in place..."
-				CommandLine="if exist $(ProjectDir)\..\..\include\SDL_config.h goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy $(ProjectDir)\..\..\include\SDL_config_win32.h $(ProjectDir)\..\..\include\SDL_config.h&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist $(ProjectDir)\..\..\include\SDL_revision.h goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;$(ProjectDir)\..\..\include\SDL_revision.h&#x0D;&#x0A;:SDLREVISIONOKAY"
+				CommandLine="if exist "$(ProjectDir)\..\..\include\SDL_config.h" goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy "$(ProjectDir)\..\..\include\SDL_config_win32.h" "$(ProjectDir)\..\..\include\SDL_config.h"&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist "$(ProjectDir)\..\..\include\SDL_revision.h" goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;"$(ProjectDir)\..\..\include\SDL_revision.h"&#x0D;&#x0A;:SDLREVISIONOKAY"
 			/>
 			<Tool
 				Name="VCCustomBuildTool"
@@ -98,7 +98,7 @@
 			<Tool
 				Name="VCPreBuildEventTool"
 				Description="Making sure basic SDL headers are in place..."
-				CommandLine="if exist $(ProjectDir)\..\..\include\SDL_config.h goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy $(ProjectDir)\..\..\include\SDL_config_win32.h $(ProjectDir)\..\..\include\SDL_config.h&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist $(ProjectDir)\..\..\include\SDL_revision.h goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;$(ProjectDir)\..\..\include\SDL_revision.h&#x0D;&#x0A;:SDLREVISIONOKAY"
+				CommandLine="if exist "$(ProjectDir)\..\..\include\SDL_config.h" goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy "$(ProjectDir)\..\..\include\SDL_config_win32.h" "$(ProjectDir)\..\..\include\SDL_config.h"&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist "$(ProjectDir)\..\..\include\SDL_revision.h" goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;"$(ProjectDir)\..\..\include\SDL_revision.h"&#x0D;&#x0A;:SDLREVISIONOKAY"
 			/>
 			<Tool
 				Name="VCCustomBuildTool"
@@ -171,7 +171,7 @@
 			<Tool
 				Name="VCPreBuildEventTool"
 				Description="Making sure basic SDL headers are in place..."
-				CommandLine="if exist $(ProjectDir)\..\..\include\SDL_config.h goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy $(ProjectDir)\..\..\include\SDL_config_win32.h $(ProjectDir)\..\..\include\SDL_config.h&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist $(ProjectDir)\..\..\include\SDL_revision.h goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;$(ProjectDir)\..\..\include\SDL_revision.h&#x0D;&#x0A;:SDLREVISIONOKAY"
+				CommandLine="if exist "$(ProjectDir)\..\..\include\SDL_config.h" goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy "$(ProjectDir)\..\..\include\SDL_config_win32.h" "$(ProjectDir)\..\..\include\SDL_config.h"&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist "$(ProjectDir)\..\..\include\SDL_revision.h" goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;"$(ProjectDir)\..\..\include\SDL_revision.h"&#x0D;&#x0A;:SDLREVISIONOKAY"
 			/>
 			<Tool
 				Name="VCCustomBuildTool"

--- a/VisualC/SDLmain/SDLmain_VS2008.vcproj
+++ b/VisualC/SDLmain/SDLmain_VS2008.vcproj
@@ -29,7 +29,7 @@
 			<Tool
 				Name="VCPreBuildEventTool"
 				Description="Making sure basic SDL headers are in place..."
-				CommandLine="if exist $(ProjectDir)\..\..\include\SDL_config.h goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy $(ProjectDir)\..\..\include\SDL_config_win32.h $(ProjectDir)\..\..\include\SDL_config.h&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist $(ProjectDir)\..\..\include\SDL_revision.h goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;$(ProjectDir)\..\..\include\SDL_revision.h&#x0D;&#x0A;:SDLREVISIONOKAY"
+				CommandLine="if exist "$(ProjectDir)\..\..\include\SDL_config.h" goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy "$(ProjectDir)\..\..\include\SDL_config_win32.h" "$(ProjectDir)\..\..\include\SDL_config.h"&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist "$(ProjectDir)\..\..\include\SDL_revision.h" goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;"$(ProjectDir)\..\..\include\SDL_revision.h"&#x0D;&#x0A;:SDLREVISIONOKAY"
 			/>
 			<Tool
 				Name="VCCustomBuildTool"
@@ -166,7 +166,7 @@
 			<Tool
 				Name="VCPreBuildEventTool"
 				Description="Making sure basic SDL headers are in place..."
-				CommandLine="if exist $(ProjectDir)\..\..\include\SDL_config.h goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy $(ProjectDir)\..\..\include\SDL_config_win32.h $(ProjectDir)\..\..\include\SDL_config.h&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist $(ProjectDir)\..\..\include\SDL_revision.h goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;$(ProjectDir)\..\..\include\SDL_revision.h&#x0D;&#x0A;:SDLREVISIONOKAY"
+				CommandLine="if exist "$(ProjectDir)\..\..\include\SDL_config.h" goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy "$(ProjectDir)\..\..\include\SDL_config_win32.h" "$(ProjectDir)\..\..\include\SDL_config.h"&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist "$(ProjectDir)\..\..\include\SDL_revision.h" goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;"$(ProjectDir)\..\..\include\SDL_revision.h"&#x0D;&#x0A;:SDLREVISIONOKAY"
 			/>
 			<Tool
 				Name="VCCustomBuildTool"
@@ -303,7 +303,7 @@
 			<Tool
 				Name="VCPreBuildEventTool"
 				Description="Making sure basic SDL headers are in place..."
-				CommandLine="if exist $(ProjectDir)\..\..\include\SDL_config.h goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy $(ProjectDir)\..\..\include\SDL_config_win32.h $(ProjectDir)\..\..\include\SDL_config.h&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist $(ProjectDir)\..\..\include\SDL_revision.h goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;$(ProjectDir)\..\..\include\SDL_revision.h&#x0D;&#x0A;:SDLREVISIONOKAY"
+				CommandLine="if exist "$(ProjectDir)\..\..\include\SDL_config.h" goto SDLCONFIGOKAY&#x0D;&#x0A;echo Copying SDL_config_win32.h to SDL_config.h...&#x0D;&#x0A;copy "$(ProjectDir)\..\..\include\SDL_config_win32.h" "$(ProjectDir)\..\..\include\SDL_config.h"&#x0D;&#x0A;:SDLCONFIGOKAY&#x0D;&#x0A;&#x0D;&#x0A;if exist "$(ProjectDir)\..\..\include\SDL_revision.h" goto SDLREVISIONOKAY&#x0D;&#x0A;echo Creating stub SDL_revision.h file...&#x0D;&#x0A;echo #define SDL_REVISION 0 &gt;"$(ProjectDir)\..\..\include\SDL_revision.h"&#x0D;&#x0A;:SDLREVISIONOKAY"
 			/>
 			<Tool
 				Name="VCCustomBuildTool"