Skip to content

L
libSDL
Switch branch/tag
  1. 14 Mar, 2006 5 commits
    • Sam Lantinga's avatar
      Fixed bug #38 · 38b0054e
      Sam Lantinga authored 
      I'm using SDL 1.2.9 with Visual C++ 7.0 on Windows 2000.

Here's the setup: my game starts in a window, with
SDL_WM_GrabInput(SDL_GRAB_ON) to constrain the cursor to the game window. The
mouse cursor is outside of the window when the game launches, and when the
window appears the cursor is grabbed and placed at the top left corner of the
inside of the game window. At this point, if I click the mouse without moving
it, the SDL_MOUSEBUTTONDOWN event's mouse coordinates are (65535,65535).

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401529
      38b0054e
    • Sam Lantinga's avatar
      Fixed bug #46 · c8264f63
      Sam Lantinga authored 
      Date: Fri, 13 Jan 2006 18:09:45 -0500
From: mhall4400 vipmail kvcc edu
Subject: Possible SDL bug

Greetings

I believe Ive come across a bug in your SDL product (1.2.9), in the CD-ROM
control portion of the library.

When calling the SDL_CDPlay() function to play the last track of a CD using the
offset and length from an SDL_CD structure generated by SDL_CDOpen(), I get the
following error from a call to SDL_Error():

mciSendCommand() error: The specified parameter is out of range for the
specified command.

The code returning the error is:
SDL_CDPlay(g_playingDriveSDLCD,
g_playingDriveSDLCD->track[trackNumberInt].offset,
g_playingDriveSDLCD->track[trackNumberInt].length)

Subtracting one from the length of the provided length seems to repair the
problem:
SDL_CDPlay(g_playingDriveSDLCD,
g_playingDriveSDLCD->track[trackNumberInt].offset,
(g_playingDriveSDLCD->track[trackNumberInt].length) - 1)

Ive replicated this problem on Windows 98 SE (several months since last
patch), fully-patched Window ME, seldom-patched Windows XP SP1, and
fully-patched Windows XP SP2.

While investigating the issue, I came across a line in your librarys win32
source code in file \src\cdrom\win32\SDL_syscdrom.c (source code zip archive
from your download page), function: SDL_SYS_CDGetTOC(), line 226 where you add
1 to the value for length to fix MCI last track length bug.  This may be the
source of the issue (because subtracting 1 from the length seems to resolve the
issue).  Microsoft may have patched the referenced bug since you wrote that
line.

Mike Hall

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401528
      c8264f63
    • Sam Lantinga's avatar
      (patch tweaked a bit) · 482c7c92
      Sam Lantinga authored 
      Date: Tue, 14 Mar 2006 03:30:11 +0000
From: Peter Mulholland
Subject: [SDL] Windows MessageBox() strangeness fixes

Hello all,

I *think* this should fix the issues that people were seeing with
MessageBox() not working and therefore assert() on mingw/msvc. Forgive
me if i've screwed up making the diff file - I'm a total newb when it
comes to things like CVS and diff.

It modifies a few files as I saw that FlushMessageQueue() was in both
the windx5 and windib driver, so I moved this into wincommon. It was
also in the gapi driver, so I changed that too. The function is now
WIN_FlushMessageQueue() in src/video/wincommon/SDL_syswm.c

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401527
      482c7c92
    • Sam Lantinga's avatar
      *** empty log message *** · e1c330b8
      Sam Lantinga authored 
      --HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401526
      e1c330b8
    • Sam Lantinga's avatar
      CFLAGS are separate from EXTRA_CFLAGS · 7c958aee
      Sam Lantinga authored 
      Fixed iconv.h detection on Cygwin32

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401525
      7c958aee
  3. 13 Mar, 2006 20 commits
  5. 12 Mar, 2006 3 commits
    • Sam Lantinga's avatar
      Blah · 5f71e5a7
      Sam Lantinga authored 
      --HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401504
      5f71e5a7
    • Sam Lantinga's avatar
      Fixed bug #150 · fa0e2110
      Sam Lantinga authored 
      memory leak in SDL_thread.c

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401503
      fa0e2110
    • Sam Lantinga's avatar
      Fixed bug #149 · ee03e101
      Sam Lantinga authored 
      --HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401502
      ee03e101
  7. 11 Mar, 2006 6 commits
    • Sam Lantinga's avatar
      Fixes from Dmitry Yakimov: · cd3a1db9
      Sam Lantinga authored 
      fixed bugs 159 and 160:

+ added threaded timers support
! fixed restoring sdl window focus (AV in windows message handler)
! disabled forgotten cdrom and joystick in config file.
* disabled minimizing sdl window while loosing focus.
  PocketPC does not have a task bar, so it is an inconvenient and unusual
  behaviour for PPC users.
+ added WIN_Paint handler for GAPI
! fixed loosing focus while using GAPI videi driver

+ added TestTimer project
* removed unnecessary macros (ENABLE_WINDIB ...) from projects

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401501
      cd3a1db9
    • Sam Lantinga's avatar
      *** empty log message *** · a5db090e
      Sam Lantinga authored 
      --HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401500
      a5db090e
    • Sam Lantinga's avatar
      Might have fixed 64-bit issues. :) · 2a752c37
      Sam Lantinga authored 
      --HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401499
      2a752c37
    • Sam Lantinga's avatar
      Fixed make distclean · c2a4bb7b
      Sam Lantinga authored 
      --HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401498
      c2a4bb7b
    • Sam Lantinga's avatar
      Clean up temporary files. I'm not sure how this got removed, but whatever... · 8feac6e1
      Sam Lantinga authored 
      --HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401497
      8feac6e1
    • Sam Lantinga's avatar
      X11 support isn't installed by default · f8abad7e
      Sam Lantinga authored 
      --HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401496
      f8abad7e
  9. 09 Mar, 2006 5 commits
  11. 08 Mar, 2006 1 commit