• Sam Lantinga's avatar
    Date: Sat, 27 Nov 2004 13:35:43 +0100 · ca383efa
    Sam Lantinga authored
    From: "Martin Bickel"
    Subject: [SDL] Patch: fixing uninitilized palette
    
    while running Valgrind over my application I found the following
    problem in SDL:
    
    The function MapNto1 allocates  SDL_Color colors[256]  but does not
    initialize it.
    SDL_DitherColors is then called which initialized the r, g and b
    component, but not the 'unused' component of each color.
    When Map1to1 is called from MapNto1, it runs a memcmp on the colors,
    which also evaluates the unused component and therefor returns
    differences much more often than necessary.
    
    So the 'unused' component of SDL_Color should be initialized. This
    patch does this by calling memset for the whole array in MapNto1 .
    
    --HG--
    extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%40998
    ca383efa
Name
Last commit
Last update
docs Loading commit data...
include Loading commit data...
src Loading commit data...
test Loading commit data...
.cvsignore Loading commit data...
BUGS Loading commit data...
Borland.html Loading commit data...
Borland.zip Loading commit data...
COPYING Loading commit data...
CREDITS Loading commit data...
CWprojects.sea.bin Loading commit data...
EpocBuildFiles.zip Loading commit data...
INSTALL Loading commit data...
MPWmake.sea.bin Loading commit data...
Makefile.am Loading commit data...
Makefile.dc Loading commit data...
PBProjects.tar.gz Loading commit data...
README Loading commit data...
README-SDL.txt Loading commit data...
README.AmigaOS Loading commit data...
README.CVS Loading commit data...
README.DC Loading commit data...
README.Epoc Loading commit data...
README.MacOS Loading commit data...
README.MacOSX Loading commit data...
README.MiNT Loading commit data...
README.NanoX Loading commit data...
README.PicoGUI Loading commit data...
README.QNX Loading commit data...
README.Qtopia Loading commit data...
README.RISCOS Loading commit data...
README.WinCE Loading commit data...
SDL.qpg.in Loading commit data...
SDL.spec.in Loading commit data...
TODO Loading commit data...
VisualC.html Loading commit data...
VisualC.zip Loading commit data...
VisualC7.zip Loading commit data...
VisualCE.zip Loading commit data...
WhatsNew Loading commit data...
acinclude.m4 Loading commit data...
autogen.sh Loading commit data...
config.guess Loading commit data...
config.sub Loading commit data...
configure.in Loading commit data...
docs.html Loading commit data...
ltmain.sh Loading commit data...
sdl-config.in Loading commit data...
sdl.m4 Loading commit data...
strip_fPIC.sh Loading commit data...