• Sam Lantinga's avatar
    Fixed bug #176 · dfa643c3
    Sam Lantinga authored
    [I'm fixing this for the public headers, but I'm not going to bother for the SDL library code (yet)]
    
    To clarify: Normaly, GCC (or, to be precise, the preprocessor) will ignore
    this, and compile the code happily. However, one can specify -Wundef to get a
    warning about this.
    
    One can probably argue whether to consider this a bug or not; but I think that
    (a) from a semantic point of view, using "#if FOO" when FOO is not defined is
    strange, and (b) since it is possible to trigger a warning about this, and a
    trivial fix exists, it should be corrected.
    
    I can think of two alternative patches, BTW:
    1) Simply use #define HAVE_FOO 0, instead of not defining HAVE_FOO at all
    2) Change
      #if HAVE_FOO
    to
      #if HAVE_FOO+0
    which always does the right thing.
    
    But I think I still prefer the attached patch :-).
    
    --HG--
    extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401633
    dfa643c3
Name
Last commit
Last update
build-scripts Loading commit data...
docs Loading commit data...
include Loading commit data...
src Loading commit data...
test Loading commit data...
.cvsignore Loading commit data...
BUGS Loading commit data...
Borland.html Loading commit data...
Borland.zip Loading commit data...
COPYING Loading commit data...
CREDITS Loading commit data...
CWprojects.sea.bin Loading commit data...
EpocBuildFiles.zip Loading commit data...
INSTALL Loading commit data...
MPWmake.sea.bin Loading commit data...
Makefile.dc Loading commit data...
Makefile.in Loading commit data...
Makefile.minimal Loading commit data...
README Loading commit data...
README-SDL.txt Loading commit data...
README.AmigaOS Loading commit data...
README.BeOS Loading commit data...
README.CVS Loading commit data...
README.DC Loading commit data...
README.Epoc Loading commit data...
README.MacOS Loading commit data...
README.MacOSX Loading commit data...
README.MiNT Loading commit data...
README.NanoX Loading commit data...
README.OS2 Loading commit data...
README.PicoGUI Loading commit data...
README.Porting Loading commit data...
README.QNX Loading commit data...
README.Qtopia Loading commit data...
README.RISCOS Loading commit data...
README.WinCE Loading commit data...
README.wscons Loading commit data...
SDL.qpg.in Loading commit data...
SDL.spec.in Loading commit data...
TODO Loading commit data...
VisualC.html Loading commit data...
VisualC.zip Loading commit data...
VisualCE.zip Loading commit data...
Watcom-OS2.zip Loading commit data...
WhatsNew Loading commit data...
acinclude.m4 Loading commit data...
autogen.sh Loading commit data...
configure.in Loading commit data...
docs.html Loading commit data...
sdl-config.in Loading commit data...
sdl.m4 Loading commit data...