• Sam Lantinga's avatar
    Fixed bug #176 · dfa643c3
    Sam Lantinga authored
    [I'm fixing this for the public headers, but I'm not going to bother for the SDL library code (yet)]
    
    To clarify: Normaly, GCC (or, to be precise, the preprocessor) will ignore
    this, and compile the code happily. However, one can specify -Wundef to get a
    warning about this.
    
    One can probably argue whether to consider this a bug or not; but I think that
    (a) from a semantic point of view, using "#if FOO" when FOO is not defined is
    strange, and (b) since it is possible to trigger a warning about this, and a
    trivial fix exists, it should be corrected.
    
    I can think of two alternative patches, BTW:
    1) Simply use #define HAVE_FOO 0, instead of not defining HAVE_FOO at all
    2) Change
      #if HAVE_FOO
    to
      #if HAVE_FOO+0
    which always does the right thing.
    
    But I think I still prefer the attached patch :-).
    
    --HG--
    extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401633
    dfa643c3
Name
Last commit
Last update
..
.cvsignore Loading commit data...
SDL.h Loading commit data...
SDL_active.h Loading commit data...
SDL_audio.h Loading commit data...
SDL_byteorder.h Loading commit data...
SDL_cdrom.h Loading commit data...
SDL_config.h.default Loading commit data...
SDL_config.h.in Loading commit data...
SDL_config_amiga.h Loading commit data...
SDL_config_dreamcast.h Loading commit data...
SDL_config_macos.h Loading commit data...
SDL_config_macosx.h Loading commit data...
SDL_config_minimal.h Loading commit data...
SDL_config_os2.h Loading commit data...
SDL_config_win32.h Loading commit data...
SDL_copying.h Loading commit data...
SDL_cpuinfo.h Loading commit data...
SDL_endian.h Loading commit data...
SDL_error.h Loading commit data...
SDL_events.h Loading commit data...
SDL_getenv.h Loading commit data...
SDL_joystick.h Loading commit data...
SDL_keyboard.h Loading commit data...
SDL_keysym.h Loading commit data...
SDL_loadso.h Loading commit data...
SDL_main.h Loading commit data...
SDL_mouse.h Loading commit data...
SDL_mutex.h Loading commit data...
SDL_name.h Loading commit data...
SDL_opengl.h Loading commit data...
SDL_platform.h Loading commit data...
SDL_quit.h Loading commit data...
SDL_rwops.h Loading commit data...
SDL_stdinc.h Loading commit data...
SDL_syswm.h Loading commit data...
SDL_thread.h Loading commit data...
SDL_timer.h Loading commit data...
SDL_types.h Loading commit data...
SDL_version.h Loading commit data...
SDL_video.h Loading commit data...
begin_code.h Loading commit data...
close_code.h Loading commit data...