• Sam Lantinga's avatar
    ate: Fri, 09 Apr 2004 20:07:10 +0200 · f17f1c01
    Sam Lantinga authored
    From: Hibernatus
    Subject: [SDL] BUG: changing video mode in opengl + windows
    
    In WIN_GL_SetupWindow (SDL12/src/video/wincommon/SDL_wingl.c) you call
    WIN_GL_ResetWindow when SetPixelFormat fails.
    WIN_GL_ResetWindow cannot properly work in its current state, because there
    are several things to update once you've created a new window. At least
    DirectInput doesn't work anymore here (which is somewhat annoying for the
    player :).
    I think you can simply remove that function. Many games don't try to
    recover from that exception, that's why the newest ATI drivers emulate 16
    bpp display in 32 bpp mode so the error never occurs (but the games may run
    much slower).
    
    Having SDL_SetVideoMode return NULL would be better than actually setting
    the video mode and losing focus, directinput and maybe directsound too. It
    also made my previous drivers crash (when switching from 32 bpp windowed to
    16 bpp fullscreen).
    
    --HG--
    extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%40890
    f17f1c01
Name
Last commit
Last update
..
Xext Loading commit data...
aalib Loading commit data...
ataricommon Loading commit data...
bwindow Loading commit data...
cybergfx Loading commit data...
dc Loading commit data...
dga Loading commit data...
directfb Loading commit data...
dummy Loading commit data...
epoc Loading commit data...
fbcon Loading commit data...
gem Loading commit data...
ggi Loading commit data...
maccommon Loading commit data...
macdsp Loading commit data...
macrom Loading commit data...
nanox Loading commit data...
photon Loading commit data...
picogui Loading commit data...
ps2gs Loading commit data...
qtopia Loading commit data...
quartz Loading commit data...
riscos Loading commit data...
svga Loading commit data...
vgl Loading commit data...
wincommon Loading commit data...
windib Loading commit data...
windx5 Loading commit data...
x11 Loading commit data...
xbios Loading commit data...
.cvsignore Loading commit data...
Makefile.am Loading commit data...
SDL_RLEaccel.c Loading commit data...
SDL_RLEaccel_c.h Loading commit data...
SDL_blit.c Loading commit data...
SDL_blit.h Loading commit data...
SDL_blit_0.c Loading commit data...
SDL_blit_1.c Loading commit data...
SDL_blit_A.c Loading commit data...
SDL_blit_N.c Loading commit data...
SDL_bmp.c Loading commit data...
SDL_cursor.c Loading commit data...
SDL_cursor_c.h Loading commit data...
SDL_gamma.c Loading commit data...
SDL_glfuncs.h Loading commit data...
SDL_leaks.h Loading commit data...
SDL_memops.h Loading commit data...
SDL_pixels.c Loading commit data...
SDL_pixels_c.h Loading commit data...
SDL_stretch.c Loading commit data...
SDL_stretch_c.h Loading commit data...
SDL_surface.c Loading commit data...
SDL_sysvideo.h Loading commit data...
SDL_video.c Loading commit data...
SDL_yuv.c Loading commit data...
SDL_yuv_mmx.c Loading commit data...
SDL_yuv_sw.c Loading commit data...
SDL_yuv_sw_c.h Loading commit data...
SDL_yuvfuncs.h Loading commit data...
blank_cursor.h Loading commit data...
default_cursor.h Loading commit data...
mmx.h Loading commit data...